summaryrefslogtreecommitdiff
path: root/server/FirewallControllerTest.cpp
diff options
context:
space:
mode:
authorBernie Innocenti <codewiz@google.com>2019-01-30 22:40:53 +0900
committerBernie Innocenti <codewiz@google.com>2019-02-01 20:07:56 +0900
commita5161a006c572aeb82b012df5dd8bcf4533b64c7 (patch)
tree15d78f24a761792ef7d3fb07fb4ada76cb434e95 /server/FirewallControllerTest.cpp
parent0b8bbc5fe3e4ee20b3b521c74cad2c6efa6323e3 (diff)
Enable more clang-tidy checks and treat them as errors
Test: tests/runtests.sh Change-Id: If59480cee6460847f5c1cef17e3ef036b8e75651
Diffstat (limited to 'server/FirewallControllerTest.cpp')
-rw-r--r--server/FirewallControllerTest.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/server/FirewallControllerTest.cpp b/server/FirewallControllerTest.cpp
index 836adb8b..71cc532f 100644
--- a/server/FirewallControllerTest.cpp
+++ b/server/FirewallControllerTest.cpp
@@ -30,7 +30,6 @@
#include "IptablesBaseTest.h"
using android::base::Join;
-using android::base::StringPrintf;
using android::base::WriteStringToFile;
namespace android {
@@ -86,8 +85,8 @@ TEST_F(FirewallControllerTest, TestCreateWhitelistChain) {
"COMMIT\n"
};
std::vector<std::pair<IptablesTarget, std::string>> expectedRestoreCommands = {
- { V4, android::base::Join(expectedRestore4, '\n') },
- { V6, android::base::Join(expectedRestore6, '\n') },
+ {V4, Join(expectedRestore4, '\n')},
+ {V6, Join(expectedRestore6, '\n')},
};
createChain("fw_whitelist", WHITELIST);
@@ -104,8 +103,8 @@ TEST_F(FirewallControllerTest, TestCreateBlacklistChain) {
"COMMIT\n"
};
std::vector<std::pair<IptablesTarget, std::string>> expectedRestoreCommands = {
- { V4, android::base::Join(expectedRestore, '\n') },
- { V6, android::base::Join(expectedRestore, '\n') },
+ {V4, Join(expectedRestore, '\n')},
+ {V6, Join(expectedRestore, '\n')},
};
createChain("fw_blacklist", BLACKLIST);
@@ -348,4 +347,4 @@ TEST_F(FirewallControllerTest, TestDiscoverMaximumValidUid) {
}
} // namespace net
-} // namespace android \ No newline at end of file
+} // namespace android