summaryrefslogtreecommitdiff
path: root/server/InterfaceController.cpp
diff options
context:
space:
mode:
authorLorenzo Colitti <lorenzo@google.com>2014-05-29 12:20:55 +0900
committerLorenzo Colitti <lorenzo@google.com>2014-05-29 12:43:00 +0900
commitce8f583ff6620a19602d3c4604557e1b1501cafa (patch)
treefb2eddc17789984cc2bb1e41bad7a7c32cb1bf7f /server/InterfaceController.cpp
parenta5d6875887a63797711093a169e7ef19c5a1ab3b (diff)
Set errno in NetworkController commands.
Set errno in the NetworkController functions that are called by CommandListener and where failure causes an operationError. This is because operationError always appends errno to its messages, and "400 481 addInterfaceToNetwork() failed (Device or resource busy)" is more useful than: "400 481 addInterfaceToNetwork() failed (Success)" We already call ALOGE to put descriptive messages in the system log, but the bugreport already conveniently aggregates all netd commands in one place in the network_management service dump, and it would help if the errno in those messages were accurate. Unfortunately many of the route and iptables commands shell out to /sbin/ip and we can't return meaningful values, but we'll fix that when (if?) we replace that with a proper netlink implementation. Bug: 15316764 Change-Id: Ia47f451029d611491aa72bca602de77333f2c6a0
Diffstat (limited to 'server/InterfaceController.cpp')
0 files changed, 0 insertions, 0 deletions