summaryrefslogtreecommitdiff
path: root/server/InterfaceController.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'server/InterfaceController.cpp')
-rw-r--r--server/InterfaceController.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/server/InterfaceController.cpp b/server/InterfaceController.cpp
index a8b985a8..9b8f64cc 100644
--- a/server/InterfaceController.cpp
+++ b/server/InterfaceController.cpp
@@ -179,12 +179,11 @@ std::string getProperty(const std::string& key, const std::string& dflt) {
};
Status setProperty(const std::string& key, const std::string& val) {
- // SetProperty tries to encode something useful in errno, however
- // the value may get clobbered by async_safe_format_log() in
- // __system_property_set(). Use with care.
+ // SetProperty does not dependably set errno to a meaningful value. Use our own error code so
+ // callers don't get confused.
return android::base::SetProperty(key, val)
? ok
- : statusFromErrno(errno, "SetProperty failed");
+ : statusFromErrno(EREMOTEIO, "SetProperty failed, see libc logs");
};