diff options
| author | Amin Hassani <ahassani@chromium.org> | 2018-06-01 11:31:34 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-06-04 17:23:39 -0700 |
| commit | 0eae427a1dac5d2896a388e5a94aad5b52079371 (patch) | |
| tree | 3daeffb198841df572f23011c4d43231fd584067 /scripts/update_payload/common.py | |
| parent | b4778293c31e2e16f60c245e2a2cf3f63151d52d (diff) | |
update_engine: Fix update check error crash
In commit 6bb001ff0c2a6b0f26e50354e6a53cd37eb780d4, the return value of
AttemptUpdateWithFlags() became dependent on the out_result of AttemptUpdate()
which is wrong. This dependency causes the error pointer not be populated when
the update check is failed/ignored. And historically, failure of the update
check does not mean the failure of the dbus signal.
BUG=chromium:848486
TEST=cros flash followed by an interactive update did not crash the update engine.
Change-Id: I440c51683bdfc9d671c38142c965466815c69f47
Reviewed-on: https://chromium-review.googlesource.com/1082979
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
Diffstat (limited to 'scripts/update_payload/common.py')
0 files changed, 0 insertions, 0 deletions