diff options
| author | Devi Sandeep Endluri V V <dendluri@codeaurora.org> | 2018-06-14 16:56:14 +0530 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2018-10-22 23:48:36 -0700 |
| commit | a469d687be733d034b5ef1c66a85c659676bd1f3 (patch) | |
| tree | 7e7417bd5cdc659bbb5edbeb379e60956e5beb0d | |
| parent | a728574dfec734dc8a11292cb0707a2542124828 (diff) | |
ipa: check return status of HAL call to avoid transaction failures
If the underlying HAL service object is invalidated and we did not get
a chance to invalidate it internally we may hit HAL transaction failure
error and the process would be forced to abort. To prevent the
transaction error we need to use the isOk check right after the HAL API
is invoked to check whether the HAL transaction was successful.
Change-Id: Idd21209f5c0407b75c2637190df5ba8158ef1a80
| -rw-r--r-- | hal/src/CtUpdateAmbassador.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/hal/src/CtUpdateAmbassador.cpp b/hal/src/CtUpdateAmbassador.cpp index 4843fe2..eba6b93 100644 --- a/hal/src/CtUpdateAmbassador.cpp +++ b/hal/src/CtUpdateAmbassador.cpp @@ -78,7 +78,10 @@ void CtUpdateAmbassador::updateTimeout(IpaNatTimeoutUpdate in) { */ ALOGE("Failed to translate timeout event :("); } else { - mFramework->updateTimeout(out); + auto ret = mFramework->updateTimeout(out); + if (!ret.isOk()) { + ALOGE("Triggering updateTimeout Callback failed."); + } } } /* updateTimeout */ |